Open
Conversation
also temporarily modfify TestDataGenerator
labkey-tchad
requested changes
Mar 26, 2026
|
|
||
| TestLogger.log("Generated random field name for domainKind " + _domainKind + ": " + randomFieldName); | ||
| return randomFieldName.name(); | ||
| return randomFieldName.name() + "\"\'"; |
Member
There was a problem hiding this comment.
Is this temporary to test in your branch or intentionally left in?
If we want this included in the long or medium-term, these characters should be appended to the names generated on lines 673 and 676 so that they are included in the name validation (isDomainAndFieldNameInvalid)
Comment on lines
+287
to
+294
| final String escapeChar = "%"; | ||
| final String problemChars = "\\\""; | ||
| final String unclean = escapeChar + problemChars; | ||
| if (!StringUtils.containsAny(name, unclean)) | ||
| return name; | ||
| var ret = FIELD_ENCODED_PREFIX + encode(name); | ||
| assert !StringUtils.containsAny(ret, problemChars); | ||
| return ret; |
Member
There was a problem hiding this comment.
How does this work with multi-value columns that need name encoding?
The getFormFieldName on line 270 would return something like %_[]quf_tricky%22stuff but I presume the actual name is []%_quf_tricky%22stuff.
If so, that method should be changed to work correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Support an encoding scheme for INPUT.name to avoid problems with multipart/form-data
Related Pull Requests
Changes